Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.7.x.mergeback #5428

Merged
merged 4 commits into from
Aug 18, 2023
Merged

V3.7.x.mergeback #5428

merged 4 commits into from
Aug 18, 2023

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Aug 17, 2023

Just testing

WARNING : when ready, must be merged to main with a merge-commit (not a squash)
This requires an iris-admin to temporarily enable merge commits

* Whats new updates for v3.7.0rc0 .
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8361532) 89.37% compared to head (f21f4c4) 89.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5428   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          89       89           
  Lines       22443    22443           
  Branches     5381     5381           
=======================================
  Hits        20058    20058           
  Misses       1639     1639           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member Author

pp-mo commented Aug 18, 2023

Rebased following merge of #5427, so it should now include the correct commits.
@HGWright please take a look.

DO NOT SQUASH-MERGE this!
When you're happy with this, let me know + I will temporarily enable the merge-with-merge-commit merging.

Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good Patrick. Approved, now you can do what you need.

@pp-mo pp-mo marked this pull request as ready for review August 18, 2023 13:57
@pp-mo pp-mo marked this pull request as draft August 18, 2023 14:09
@pp-mo pp-mo marked this pull request as ready for review August 18, 2023 14:09
@HGWright HGWright merged commit 368c2d8 into SciTools:main Aug 18, 2023
15 checks passed
@pp-mo
Copy link
Member Author

pp-mo commented Aug 18, 2023

Thanks @HGWright !
That finally concludes the v3.7 release.

At least it is the end of the "do nothing script" tasks, but @trexfeathers + I now have some suggested improvements to the process to work on.

@pp-mo pp-mo deleted the v3.7.x.mergeback branch August 31, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants